-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_es: support write_operation option #4079
Conversation
Configuration example |
Test result result of command (in ./build dir): (cmake -DFLB_DEV=On -DFLB_TESTS_RUNTIME=On -DFLB_TESTS_INTERNAL=On .. && make && valgrind bin/flb-rt-out_elasticsearch) 2>&1 | tee /tmp/fluent-test.log |
Valgrind output result of command (in ./build dir): (cmake -DFLB_DEV=On -DFLB_TESTS_RUNTIME=On -DFLB_TESTS_INTERNAL=On .. && make && valgrind bin/fluent-bit -c /tmp/elasticsearch.conf.txt) 2>&1 | tee /tmp/fluent-valgrind.log |
Signed-off-by: Zhanibek Adilbekov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you attach valgrind output again ?
Below file is incomplete.
There is no summary information.
#4079 (comment)
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
@liljaylj ping |
here you go) new valgrind log after latest commit |
Sorry, it was tough lately. Multiple projects was going to production) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liljaylj Thank you for updating.
I added some requests. Could you check them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing and sorry for several requests.
- Could you fix conflicts?
- Could you modify commit message ?
It should beout_es: something
notfix: something
Signed-off-by: Zhanibek Adilbekov <[email protected]>
Signed-off-by: Zhanibek Adilbekov <[email protected]>
Signed-off-by: Zhanibek Adilbekov <[email protected]>
…ates memory. Signed-off-by: Zhanibek Adilbekov <[email protected]>
oh, sorry, my bad. |
@liljaylj Thank you for quick response. DCO error is reported for latest commit. |
Signed-off-by: Zhanibek Adilbekov <[email protected]>
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM.
* out_es: support write_operation option Signed-off-by: Zhanibek Adilbekov <[email protected]>
Adds
write_operation
option as in fluentd-plugin-elasticsearch (https://github.com/uken/fluent-plugin-elasticsearch#write_operation)Fixes: #1430
Testing
Before we can approve your change; please submit the following in a comment:
Documentation
fluent/fluent-bit-docs#603
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.