out_s3: fix use-after-free in destructor #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
code looks good to me. Just the branch is out of date, please update the branch |
|
@DrewZhang13 Rebased onto latest master. |
|
@DrewZhang13 That test failure seems unrelated. Not sure what to do about it. |
|
can you re-run the checks see if it could be fixed? |
|
@DrewZhang13 I don't think I have that ability on my end. Only thing I can do is push again to retrigger all the actions. |
|
Test pass this time, good to merge |
PettitWesley
previously approved these changes
Jul 9, 2021
|
@rittneje Thanks for this! Please rebase this commit with latest master and then we can merge it. |
Signed-off-by: Jesse Rittner <[email protected]>
|
@PettitWesley rebased |
PettitWesley
approved these changes
Jul 9, 2021
|
@rittneje Please also submit this commit against the newly created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesse Rittner [email protected]
Fixes #3732.
cc @PettitWesley @DrewZhang13
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
s3-fix-valgrind-results.txt
Documentation
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.