build: fix CMakeLists.txt for libbacktrace #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarandia
force-pushed
the
fixcrosscompile
branch
3 times, most recently
from
6b4f11e to
87cd397
Compare
|
@niedbalski We discovered that we needed to do a bit more in the CMakeLists.txt and our new cmake file following #3152 . PTAL. Thanks! |
We need to pass the --host to libbacktrace in order for it to cross-compile correctly. Also, we need some additional environment variables in cmake/linux-arm64.cmake to ensure the dependencies are linked correctly during a Docker build. Tested this locally and on a Kubernetes cluster. Signed-off-by: Ziyuan Chen <[email protected]>
sarandia
force-pushed
the
fixcrosscompile
branch
from
87cd397 to
57804eb
Compare
|
LGTM, @edsiper mind to review and +2 |
sarandia
added a commit
to sarandia/fluent-bit
that referenced
this pull request
Mar 26, 2021
PR fluent#3210 didn't reflect our latest working copy because it was dropped when rebasing on fluent#3225. Re-submitting this tested working Dockerfile for Arm64v8.
sarandia
added a commit
to sarandia/fluent-bit
that referenced
this pull request
Mar 26, 2021
PR fluent#3210 didn't reflect our latest working copy because it was dropped when rebasing on fluent#3225. Re-submitting this tested working Dockerfile for Arm64v8. Signed-off-by: Ziyuan Chen <[email protected]>
sarandia
added a commit
to sarandia/fluent-bit
that referenced
this pull request
Mar 26, 2021
PR fluent#3210 didn't reflect our latest working copy because it was dropped when rebasing on fluent#3225. Re-submitting this tested working Dockerfile for Arm64v8. Signed-off-by: Ziyuan Chen <[email protected]>
sarandia
added a commit
to sarandia/fluent-bit
that referenced
this pull request
Mar 26, 2021
PR fluent#3210 didn't reflect our latest working copy because it was dropped when rebasing on fluent#3225. Re-submitting this tested working Dockerfile for Arm64v8. Signed-off-by: Ziyuan Chen <[email protected]>
niedbalski
pushed a commit
that referenced
this pull request
Apr 6, 2021
PR #3210 didn't reflect our latest working copy because it was dropped when rebasing on #3225. Re-submitting this tested working Dockerfile for Arm64v8. Signed-off-by: Ziyuan Chen <[email protected]>
DrewZhang13
pushed a commit
to DrewZhang13/fluent-bit
that referenced
this pull request
May 3, 2021
We need to pass the --host to libbacktrace in order for it to cross-compile correctly. Also, we need some additional environment variables in cmake/linux-arm64.cmake to ensure the dependencies are linked correctly during a Docker build. Tested this locally and on a Kubernetes cluster. Signed-off-by: Ziyuan Chen <[email protected]>
DrewZhang13
pushed a commit
to DrewZhang13/fluent-bit
that referenced
this pull request
May 3, 2021
PR fluent#3210 didn't reflect our latest working copy because it was dropped when rebasing on fluent#3225. Re-submitting this tested working Dockerfile for Arm64v8. Signed-off-by: Ziyuan Chen <[email protected]>
DrewZhang13
pushed a commit
to DrewZhang13/fluent-bit
that referenced
this pull request
May 3, 2021
We need to pass the --host to libbacktrace in order for it to cross-compile correctly. Also, we need some additional environment variables in cmake/linux-arm64.cmake to ensure the dependencies are linked correctly during a Docker build. Tested this locally and on a Kubernetes cluster. Signed-off-by: Ziyuan Chen <[email protected]>
DrewZhang13
pushed a commit
to DrewZhang13/fluent-bit
that referenced
this pull request
May 3, 2021
PR fluent#3210 didn't reflect our latest working copy because it was dropped when rebasing on fluent#3225. Re-submitting this tested working Dockerfile for Arm64v8. Signed-off-by: Ziyuan Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pass the --host to libbacktrace in order for it to
cross-compile correctly
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Documentation
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.