Change the default _type to be _doc #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should also mention that the documentation would need to be updated, just wanted to get some feedback on the approach (whether we want to change the default to "_doc" or just explicitly set the type on index creation time). |
In order to be compatible with the new versions of ElasticSearch which effectively are getting rid of _type, we should change the default type to be "_doc" As per the ElasticSearch forum discussion at: https://discuss.elastic.co/t/7-0-1-template-with-geo-point-geoip-processor-in-pipeline-bulk-crash/182039/3 this seems to be due to not specifying a _type when creating the mapping, at which point it defaults to "_doc". Later when performing a bulk operation (indexing) we specifying that _type is "flb_type" which then causes the error to be thrown about multiple types not being allowed: "Rejecting mapping update to [logs-2019.11.16] as the final mapping would have more than 1 type: [_doc, flb_type]" Another possible solution to this issue might be to use the "flb_type" when creating the index (and mappings) initially, however I'm not sure whether this type is being used for anything (we are not filtering or querying based on it). Issue(s): fluent#1359 Signed-off-by: Srdan Dukic <[email protected]>
|
Can this be merged, please? |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be compatible with the new versions of ElasticSearch which effectively are getting rid of
_type, we should change the default type to be "_doc"
As per the ElasticSearch forum discussion at:
https://discuss.elastic.co/t/7-0-1-template-with-geo-point-geoip-processor-in-pipeline-bulk-crash/182039/3
this seems to be due to not specifying a _type when creating the mapping, at which point it defaults
to "_doc".
Later when performing a bulk operation (indexing) we specifying that _type is "flb_type" which then
causes the error to be thrown about multiple types not being allowed:
"Rejecting mapping update to [logs-2019.11.16] as the final mapping would have more than 1 type: [_doc, flb_type]"
Another possible solution to this issue might be to use the "flb_type" when creating the index (and mappings)
initially, however I'm not sure whether this type is being used for anything (we are not filtering or querying
based on it).
Issue(s): #1359