Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required dependencies for docker build #1271

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

wfernandes
Copy link
Member

Signed-off-by: Warren Fernandes [email protected]

@wfernandes
Copy link
Member Author

The force-push was to rebase onto current master for your convenience. 😉 👍

@edsiper
Copy link
Member

edsiper commented Apr 12, 2019

thanks for the contribution.

Why libjemalloc-dev ?

@edsiper edsiper added the waiting-for-user Waiting for more information, tests or requested changes label Apr 12, 2019
@edsiper edsiper self-assigned this Apr 12, 2019
@wfernandes
Copy link
Member Author

@edsiper It was added as a dependency earlier on. We added it to the Dockerfile because the docker image wouldn't build without it.

@wfernandes
Copy link
Member Author

wfernandes commented Apr 12, 2019

I see it being added updated as part of this commit 4641443 to the project.

@edsiper
Copy link
Member

edsiper commented Apr 12, 2019

I troubleshoot the Jemalloc header issue, it was a problem of a directory context due to the new path of the stream processor, the fix has been pushed: 00dd804

On this case including libjemalloc-dev could generate issues since we bundle Jemalloc and likely headers can be different from the one provided in the build system v/s the bundled in Fluent Bit.

Please adjust the file Dockerfile change since it should be ok now.

@edsiper edsiper merged commit 99ef137 into fluent:master Apr 15, 2019
@edsiper
Copy link
Member

edsiper commented Apr 15, 2019

thanks.

note: I've squashed and changed the commit subject to

dockerfile: add required dependencies for docker build (#1271)

@wfernandes wfernandes deleted the fix-dockerfile branch April 19, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-user Waiting for more information, tests or requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants