out_opentelemetry: Prevent null dereference on memcpy (CID 507910)

Signed-off-by: Hiroshi Hatake <[email protected]>
fluent · Aug 30, 2024 · e5c021c · e5c021c
1 parent d873502
commit e5c021c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/plugins/out_opentelemetry/opentelemetry_utils.c b/plugins/out_opentelemetry/opentelemetry_utils.c
@@ -334,13 +334,15 @@ Opentelemetry__Proto__Common__V1__AnyValue *msgpack_bin_to_otlp_any_value(struct
         result->bytes_value.len = o->via.bin.size;
         result->bytes_value.data = flb_malloc(o->via.bin.size);
 
-        if (result->bytes_value.data == NULL) {
+        if (result->bytes_value.data) {
+            memcpy(result->bytes_value.data, o->via.bin.ptr, o->via.bin.size);
+        }
+        else {
             otlp_any_value_destroy(result);
 
             result = NULL;
         }
 
-        memcpy(result->bytes_value.data, o->via.bin.ptr, o->via.bin.size);
     }
 
     return result;