This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 249
Added Daemonset yaml for Kubernetes cluster v1.16+ and updated README. #71
Open
AATHITH
wants to merge
5
commits into
fluent:master
Choose a base branch
from
AATHITH:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AATHITH
commented
Apr 6, 2020
•
edited
Loading
edited
- Added a fluent-bit-Daemonset YAML file(new API version and selectors) which works in kubernetes cluster v1.16 and above.
- Added kubectl create command for that in README.md file.
- Removed Duplicate to fix Readme is repetitive #67
AATHITH
force-pushed
the
master
branch
2 times, most recently
from
April 6, 2020 10:06
a12bee4
to
5fa4fa7
Compare
AATHITH
changed the title
Added Daemonset yaml for Kubernetes cluster v1.16 and above
Added Daemonset yaml for Kubernetes cluster v1.16+ and updated README.
Apr 6, 2020
vandiedakaf
reviewed
May 5, 2020
version: v1 | ||
kubernetes.io/cluster-service: "true" | ||
spec: | ||
selectors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this line gave me an error. I had to change it to the singular form 'selector'.
[ValidationError(DaemonSet.spec): unknown field "selectors" in io.k8s.api.apps.v1.
DaemonSetSpec, ValidationError(DaemonSet.spec): missing required field "selector" in io.k8s.api.apps.v1.DaemonSetSpec]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for pointing out. Fixed.
I think we should not add a new file, just make all adjustments assuming everybody is on > 1.16 |
This YAML is compatible with kubernetes version 1.16 and above. Signed-off-by: AATHITH <[email protected]>
added kubectl create daemonset command for Kubernetes cluster v1.16 and above Signed-off-by: AATHITH <[email protected]> modified: README.md Signed-off-by: AATHITH <[email protected]>
Signed-off-by: AATHITH <[email protected]>
Signed-off-by: AATHITH <[email protected]>
Signed-off-by: AATHITH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.