Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar updates in configuration-file.md #604

Closed
wants to merge 1 commit into from
Closed

Grammar updates in configuration-file.md #604

wants to merge 1 commit into from

Conversation

Tomy8s
Copy link

@Tomy8s Tomy8s commented Sep 16, 2021

A few small grammar fixes.

agup006
agup006 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@agup006 agup006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good, and appreciate the changes

@agup006
Copy link
Member

agup006 commented Oct 27, 2021

@Tomy8s can you fix DCO for us to merge?

@edsiper
Copy link
Member

edsiper commented Dec 12, 2021

@Tomy8s pls fix conflicts and sign-off the commit to avoid DCO issue

@edsiper edsiper added the waiting-for-user Waiting for user/contributors feedback or requested changes label Dec 12, 2021
@lecaros
Copy link
Contributor

lecaros commented Dec 14, 2021

@Tomy8s, please fix DCO so we can merge your contribution. If you have doubts, please take a look into https://github.com/fluent/fluent-bit-docs/blob/master/CONTRIBUTING.md

@lecaros lecaros added the dco DCO failing label Dec 14, 2021
@lecaros lecaros added the conflict Waiting on conflict to be resolved by contributor label Jan 6, 2022
@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Oct 22, 2022
@esmerel esmerel mentioned this pull request Oct 29, 2024
Merged
@esmerel
Copy link
Contributor

esmerel commented Oct 29, 2024

These changes are incorporated into #1493

@esmerel esmerel closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agup006 agup006 agup006 approved these changes

Assignees
No one assigned
Labels
conflict Waiting on conflict to be resolved by contributor dco DCO failing Stale waiting-for-user Waiting for user/contributors feedback or requested changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tomy8s @agup006 @edsiper @lecaros @esmerel