Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines: filters: parser: Add a nest_under parameter #1543

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

RaJiska
Copy link

@RaJiska RaJiska commented Jan 13, 2025

Documentation for PR fluent/fluent-bit#9828

@RaJiska RaJiska requested review from a team as code owners January 13, 2025 09:44
Copy link
Member

@alexakreizinger alexakreizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a few suggestions for style and clarity, but LGTM!

and thanks for opening a PR :)

pipeline/filters/parser.md Outdated Show resolved Hide resolved
pipeline/filters/parser.md Outdated Show resolved Hide resolved
pipeline/filters/parser.md Outdated Show resolved Hide resolved
pipeline/filters/parser.md Outdated Show resolved Hide resolved
RaJiska and others added 4 commits January 18, 2025 12:24
Co-authored-by: Alexa Kreizinger <[email protected]>
Signed-off-by: Doriann Corlouër <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]>
Signed-off-by: Doriann Corlouër <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]>
Signed-off-by: Doriann Corlouër <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]>
Signed-off-by: Doriann Corlouër <[email protected]>
@RaJiska
Copy link
Author

RaJiska commented Jan 18, 2025

All good to me! Thanks @alexakreizinger for helping making it clearer and in proper English~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants