Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: outputs: dash0: Added Dash0 documentation #1532

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

CodingFabian
Copy link
Contributor

@CodingFabian CodingFabian commented Dec 17, 2024

Added documentation on how to send logs to dash0 based on the OpenTelemetry output plugin.

pipeline/outputs/dash0.md Show resolved Hide resolved
pipeline/outputs/dash0.md Show resolved Hide resolved
pipeline/outputs/dash0.md Show resolved Hide resolved
pipeline/outputs/dash0.md Outdated Show resolved Hide resolved
@CodingFabian CodingFabian force-pushed the dash0-docs branch 2 times, most recently from d9eb2a8 to d51047b Compare December 17, 2024 10:17
@CodingFabian CodingFabian changed the title Added Dash0 documentation pipeline: outputs: dash0: Added Dash0 documentation Dec 17, 2024
Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from technical perspective but will allow docs (@fluent/chronosphere-tech-writers ) to confirm the writing perspective.

Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions so we're using proper nouns properly =)

I'll go ahead and approve as well, if you'd update those two changes that'd be great.

And thanks for updating the spelling dictionary!

pipeline/outputs/dash0.md Outdated Show resolved Hide resolved
pipeline/outputs/dash0.md Outdated Show resolved Hide resolved
@CodingFabian
Copy link
Contributor Author

@esmerel I have changed all references to your proposed version in:
9a5befa
left the other commit just for dash0

Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, one thing left to do is add your new page to https://github.com/fluent/fluent-bit-docs/blob/master/SUMMARY.md so it appears @CodingFabian

@patrick-stephens patrick-stephens merged commit 5c614fb into fluent:master Dec 18, 2024
3 checks passed
@CodingFabian CodingFabian deleted the dash0-docs branch December 18, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants