-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipeline: outputs: dash0: Added Dash0 documentation #1532
Conversation
44b24f9
to
7608cb7
Compare
d9eb2a8
to
d51047b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine from technical perspective but will allow docs (@fluent/chronosphere-tech-writers ) to confirm the writing perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions so we're using proper nouns properly =)
I'll go ahead and approve as well, if you'd update those two changes that'd be great.
And thanks for updating the spelling dictionary!
Signed-off-by: Fabian Lange <[email protected]>
Signed-off-by: Fabian Lange <[email protected]>
d51047b
to
9a5befa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, one thing left to do is add your new page to https://github.com/fluent/fluent-bit-docs/blob/master/SUMMARY.md so it appears @CodingFabian
Added documentation on how to send logs to dash0 based on the OpenTelemetry output plugin.