Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines: docs: bringing elasticsearch up to standards #1478

Conversation

esmerel
Copy link
Contributor

@esmerel esmerel commented Oct 21, 2024

Signed-off-by: Lynette Miles [email protected]

@esmerel esmerel requested review from a team as code owners October 21, 2024 21:22
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some minor changes like adding none to the Default column where no value exists instead of suggesting it in the PR 10 times.

@esmerel
Copy link
Contributor Author

esmerel commented Oct 22, 2024

yeah i hadn't initially done it because I wasn't sure what -should- go there and leaving it blank in this case didn't seem unreasonable.

@esmerel esmerel force-pushed the lynettemiles/sc-113677/update-pipeline-outputs-elasticsearch-for branch from df63d75 to 782512e Compare October 22, 2024 20:37
@esmerel esmerel merged commit 0d26e33 into master Oct 22, 2024
5 checks passed
@esmerel esmerel deleted the lynettemiles/sc-113677/update-pipeline-outputs-elasticsearch-for branch October 22, 2024 20:46
@esmerel esmerel mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants