Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: outputs: loki: document structured metadata #1406

Merged
merged 8 commits into from
Jul 17, 2024

Conversation

jtackaberry
Copy link
Contributor

This is the documentation for fluent/fluent-bit#9048

@jtackaberry jtackaberry force-pushed the loki-structured-metadata branch from fc0e1bc to 55b400e Compare July 13, 2024 17:00
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! I suggested some edits and changes to better align the content with our style, tone, and voice.

pipeline/outputs/loki.md Outdated Show resolved Hide resolved
pipeline/outputs/loki.md Outdated Show resolved Hide resolved
pipeline/outputs/loki.md Outdated Show resolved Hide resolved
pipeline/outputs/loki.md Outdated Show resolved Hide resolved
pipeline/outputs/loki.md Outdated Show resolved Hide resolved
pipeline/outputs/loki.md Outdated Show resolved Hide resolved
pipeline/outputs/loki.md Outdated Show resolved Hide resolved
jtackaberry and others added 6 commits July 17, 2024 13:24
Co-authored-by: Adam Locke <[email protected]>
Signed-off-by: Jason Tackaberry <[email protected]>
Co-authored-by: Adam Locke <[email protected]>
Signed-off-by: Jason Tackaberry <[email protected]>
Co-authored-by: Adam Locke <[email protected]>
Signed-off-by: Jason Tackaberry <[email protected]>
Co-authored-by: Adam Locke <[email protected]>
Signed-off-by: Jason Tackaberry <[email protected]>
Co-authored-by: Adam Locke <[email protected]>
Signed-off-by: Jason Tackaberry <[email protected]>
Co-authored-by: Adam Locke <[email protected]>
Signed-off-by: Jason Tackaberry <[email protected]>
@jtackaberry
Copy link
Contributor Author

@lockewritesdocs thanks for the review! All suggestions have been merged, except for the last one until we can decide on whether it ought to be tweaked further.

Co-authored-by: Adam Locke <[email protected]>
Signed-off-by: Jason Tackaberry <[email protected]>
@jtackaberry
Copy link
Contributor Author

All suggestions merged. I assume you'll want to squash-merge this PR :)

@lockewritesdocs lockewritesdocs self-requested a review July 17, 2024 20:08
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

@lockewritesdocs lockewritesdocs merged commit 6be766a into fluent:master Jul 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants