Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines: outputs: kafka: Document the raw_log_key #1397

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

zecke
Copy link
Contributor

@zecke zecke commented Jun 19, 2024

This is similar to the log_key in other outputs, e.g. the cloudwatch one.

@zecke zecke requested review from a team as code owners June 19, 2024 12:51
This is similar to the log_key in other outputs, e.g. the cloudwatch
one.

Signed-off-by: Holger Hans Peter Freyther <[email protected]>
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! I suggested some editorial changes to help align with Chronosphere tone and style.

pipeline/outputs/kafka.md Outdated Show resolved Hide resolved
pipeline/outputs/kafka.md Outdated Show resolved Hide resolved
zecke and others added 2 commits June 21, 2024 06:48
Co-authored-by: Adam Locke <[email protected]>
Signed-off-by: Holger Freyther <[email protected]>
Co-authored-by: Adam Locke <[email protected]>
Signed-off-by: Holger Freyther <[email protected]>
Replace "dummy" with "example."

Signed-off-by: Adam Locke <[email protected]>
@lockewritesdocs lockewritesdocs self-requested a review June 21, 2024 12:56
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating changes! LGTM 🦖

@patrick-stephens patrick-stephens merged commit 0bb36bd into fluent:master Jun 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants