Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[documentation] upd tcp and kafka plugin docs #1312

Merged
merged 9 commits into from
Jul 9, 2024
Merged

[documentation] upd tcp and kafka plugin docs #1312

merged 9 commits into from
Jul 9, 2024

Conversation

brunooliveiramac
Copy link
Contributor

@brunooliveiramac brunooliveiramac commented Feb 16, 2024 •
edited
Loading

Add documentation for:

  • Threaded option for Kafka input plugin
  • Workers option for Kafka output plugin

@brunooliveiramac brunooliveiramac changed the title upd tcp and kafka docs [documentation] upd tcp and kafka plugin docs Feb 16, 2024
@patrick-stephens
Copy link
Contributor

Can you provide some context in the description please?
@leonardo-albertovich do we want a general section on threaded support somewhere?

@lecaros lecaros added the waiting-for-user Waiting for user/contributors feedback or requested changes label Feb 21, 2024
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label May 22, 2024
@brunooliveiramac brunooliveiramac requested review from a team as code owners July 6, 2024 17:37
@brunooliveiramac
Copy link
Contributor Author

@patrick-stephens could you check if that is enough :D

@github-actions github-actions bot removed the Stale label Jul 7, 2024
cnorris-cs
cnorris-cs reviewed Jul 8, 2024
View reviewed changes
pipeline/inputs/tcp.md Outdated Show resolved Hide resolved
cnorris-cs
cnorris-cs reviewed Jul 8, 2024
View reviewed changes
pipeline/inputs/tcp.md Outdated Show resolved Hide resolved
cnorris-cs
cnorris-cs reviewed Jul 8, 2024
View reviewed changes
pipeline/inputs/tcp.md Outdated Show resolved Hide resolved
cnorris-cs
cnorris-cs reviewed Jul 8, 2024
View reviewed changes
pipeline/inputs/udp.md Outdated Show resolved Hide resolved
brunooliveiramac and others added 5 commits July 8, 2024 10:51
@brunooliveiramac @cnorris-cs
Update pipeline/inputs/tcp.md
68e7126 
Co-authored-by: Craig Norris <[email protected]>
Signed-off-by: Bruno Oliveira <[email protected]>
@brunooliveiramac @cnorris-cs
Update pipeline/inputs/tcp.md
e4a33c6 
Co-authored-by: Craig Norris <[email protected]>
Signed-off-by: Bruno Oliveira <[email protected]>
@brunooliveiramac @cnorris-cs
Update pipeline/inputs/udp.md
eedfb70 
Co-authored-by: Craig Norris <[email protected]>
Signed-off-by: Bruno Oliveira <[email protected]>
@brunooliveiramac @cnorris-cs
Update pipeline/inputs/tcp.md
444c32c 
Co-authored-by: Craig Norris <[email protected]>
Signed-off-by: Bruno Oliveira <[email protected]>
@brunooliveiramac @cnorris-cs
Update pipeline/outputs/kafka.md
e564b4b 
Co-authored-by: Craig Norris <[email protected]>
Signed-off-by: Bruno Oliveira <[email protected]>
cnorris-cs
cnorris-cs approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@cnorris-cs cnorris-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from a technical writing perspective, and I'll add my approval based on that. This shouldn't replace any technical review of the content, but formatting-wise it looks good. Thanks for making those changes!

@patrick-stephens patrick-stephens merged commit f6d77c8 into fluent:master Jul 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnorris-cs cnorris-cs cnorris-cs approved these changes

@tonyschak tonyschak tonyschak approved these changes

@patrick-stephens patrick-stephens patrick-stephens approved these changes

Assignees
No one assigned
Labels
waiting-for-user Waiting for user/contributors feedback or requested changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brunooliveiramac @patrick-stephens @tonyschak @cnorris-cs @lecaros