Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for uri parameter to outputs/loki #1287

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Added documentation for uri parameter to outputs/loki #1287

merged 2 commits into from
Jan 11, 2024

Conversation

PeterStolz
Copy link
Contributor

I opened fluent/fluent-bit#8348 thinking that there was no option to set uri/path for the loki output plugin, but when checking how to implement it I found out it already exists

https://github.com/fluent/fluent-bit/blob/cd497e38dc8e4e958756b449aab34801da486ad2/plugins/out_loki/loki.c#L1741-L1748

@PeterStolz PeterStolz marked this pull request as draft January 10, 2024 13:41
@PeterStolz
Copy link
Contributor Author

Nevermind. While it exists in source there is some validation inbetween preventing me from using it directly

@PeterStolz PeterStolz closed this Jan 10, 2024
@PeterStolz
Copy link
Contributor Author

Nevermind I did not run the latest version of fluent-bit. Setting uri works fine.

@PeterStolz PeterStolz reopened this Jan 10, 2024
@PeterStolz PeterStolz marked this pull request as ready for review January 10, 2024 13:56
Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified via docker run --rm -it fluent/fluent-bit:2.2.1 -o loki --help

@patrick-stephens patrick-stephens merged commit 9509165 into fluent:master Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants