Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stackdriver.md with warning about Workers option #1278

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

gerry-tock
Copy link
Contributor

Adding this info about this issue because I lost a bunch of time trying to chase down intermittent restarts of my fluent-bit pods (v.2.2.0).

Even if it defaults to 1 in newer versions, someone may override it, as was my case.

Until the underlying issue is fixed, I think it's helpful to warn others about this.

Adding this info about this issue because I lost a bunch of time trying to chase down intermittent restarts of my fluent-bit pods (v.2.2.0). 

Even if it defaults to 1 in newer versions, someone may override it, as was my case. 

Until the underlying issue is fixed, I think it's helpful to warn others about this.

Signed-off-by: Gerry Laracuente <[email protected]>
@gerry-tock gerry-tock changed the title Update stackdriver.md Update stackdriver.md with warning about Workers option Dec 22, 2023
pipeline/outputs/stackdriver.md Outdated Show resolved Hide resolved
When the number of Workers is greater than 1, fluent-bit may interimittently crash.

```
[2023/06/07 08:15:30] [engine] caught signal (SIGSEGV)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly to the title, this could be anything and isn't specific to this crash with the workers so I would recommend not including it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably say "you may see this" or something similar. However it could be any crash really.

pipeline/outputs/stackdriver.md Outdated Show resolved Hide resolved
@patrick-stephens
Copy link
Contributor

@gerry-tock could you just tweak based on the comments? I agree it's important to merge.

gerry-tock and others added 3 commits January 19, 2024 10:41
Co-authored-by: Braydon Kains <[email protected]>
Signed-off-by: Gerry Laracuente <[email protected]>
Co-authored-by: Braydon Kains <[email protected]>
Signed-off-by: Gerry Laracuente <[email protected]>
Signed-off-by: Gerry Laracuente <[email protected]>
@patrick-stephens patrick-stephens enabled auto-merge (squash) January 19, 2024 15:56
@patrick-stephens
Copy link
Contributor

@braydonk if you approve it should auto-merge

@patrick-stephens patrick-stephens merged commit fe31303 into fluent:master Jan 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants