Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hands-on.md to add missing -p read_from_head=true #1261

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

ecerulm
Copy link
Contributor

@ecerulm ecerulm commented Nov 24, 2023

The current Hands On! 101 is missing the -p read_from_head=true= on the "4. Calculate Average Value" example.

If you run the current example you get

[2023/11/24 10:40:10] [ info] [sp] registered task: flb-console:0
[2023/11/24 10:40:10] [ info] [input:tail:tail.0] inotify_fs_add(): inode=5 watch_fd=1 name=/sp-samples-1k.log

and not more output. There is no {"AVG(num)"=>61.230770}. in the output.

By adding the -p read_from_head=true I get the expected output

[2023/11/24 10:42:02] [ info] [sp] registered task: flb-console:0
[0] [1700822522.779461868, {"AVG(num)"=>61.230770}]
[0] [1700822522.780739544, {"AVG(num)"=>47.842106}]
[0] [1700822522.781954929, {"AVG(num)"=>40.647060}]
[0] [1700822522.783120630, {"AVG(num)"=>56.812500}]
[0] [1700822522.783183144, {"AVG(num)"=>99.000000}]
[2023/11/24 10:42:02] [ info] [input:tail:tail.0] inotify_fs_add(): inode=5 watch_fd=1 name=/sp-samples-1k.log

@lecaros
Copy link
Contributor

lecaros commented Nov 24, 2023

Hi @ecerulm. Thanks for this contribution.
Could you please review https://github.com/fluent/fluent-bit-docs/blob/master/CONTRIBUTING.md and modify your commit messages accordingly?

@ecerulm
Copy link
Contributor Author

ecerulm commented Nov 24, 2023

@lecaros , done! (I think)

@lecaros lecaros merged commit 2ea4855 into fluent:master Nov 24, 2023
4 checks passed
@lecaros
Copy link
Contributor

lecaros commented Nov 24, 2023

Merged. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants