-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installation: platforms: add s390x to supported architectures #1245
Conversation
Signed-off-by: Ajay <[email protected]>
4c572ec
to
4e54faf
Compare
Signed-off-by: Ajay <[email protected]> Signed-off-by: Ajay Victor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the specific unsupported plugin pages need updating as well, e.g. for exec
we already call out we do not support it in containers: https://docs.fluentbit.io/manual/pipeline/inputs/exec#container-support
Co-authored-by: Pat <[email protected]> Signed-off-by: Ajay P Victor <[email protected]>
Signed-off-by: Ajay Victor <[email protected]>
511623c
to
10ce457
Compare
installation/supported-platforms.md
Outdated
@@ -14,7 +14,7 @@ The following operating systems and architectures are supported in Fluent Bit. | |||
| | [Debian 12 \(Bookworm\)](linux/debian.md) | x86\_64, Arm64v8 | | |||
| | [Debian 11 \(Bullseye\)](linux/debian.md) | x86\_64, Arm64v8 | | |||
| | [Debian 10 \(Buster\)](linux/debian.md) | x86\_64, Arm64v8 | | |||
| | [Ubuntu 22.04 \(Jammy Jellyfish\)](linux/ubuntu.md) | x86\_64, Arm64v8 | | |||
| | [Ubuntu 22.04 \(Jammy Jellyfish\)](linux/ubuntu.md) | x86\_64, Arm64v8, s390x | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? We do not seem to explicitly do anything to provide any DEBs for s390x which is what this table is showing - actual packages are built and provided officially from our repos. Not that it can be but that it is.
The only changes in the linked PR are to build images, not packages, so want to confirm. If we want to build it via the normal ./packaging/build.sh -d <distro>
then how do we do that?
I would extend the statement about container images being provided with something along the lines of "it is possible to build for Ubuntu 22.04 as well".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed..
pipeline/inputs/exec.md
Outdated
@@ -8,7 +8,7 @@ command arguments could lead to malicious command execution. | |||
|
|||
## Container support | |||
|
|||
This plugin will not function in the distroless production images (AMD64 currently) as it needs a functional `/bin/sh` which is not present. | |||
This plugin will not function in the distroless production images (AMD64 and s390x currently) as it needs a functional `/bin/sh` which is not present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs updating, all production images are distroless so this was out of date for a while. No container images support this plugin other than the debug ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated..
Signed-off-by: Ajay Victor <[email protected]>
Adding doc changes as part of enabling s390x.
Related PR: fluent/fluent-bit#8095