Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: outputs: loki: Add new header options #1207

Merged
merged 2 commits into from
May 24, 2024
Merged

pipeline: outputs: loki: Add new header options #1207

merged 2 commits into from
May 24, 2024

Conversation

alarobric
Copy link
Contributor

@alarobric alarobric commented Sep 26, 2023

Tied to changes in fluent/fluent-bit#7979

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 26, 2023
@lecaros lecaros added waiting-for-user Waiting for user/contributors feedback or requested changes conflict Waiting on conflict to be resolved by contributor and removed Stale labels Feb 21, 2024
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label May 22, 2024
@alarobric alarobric requested review from a team as code owners May 22, 2024 16:22
@patrick-stephens
Copy link
Contributor

Should there be a uri config as well?

@alarobric
Copy link
Contributor Author

Should there be a uri config as well?

Yes that was originally in this PR, but it was added previously by someone else. That was just removed when I resolved the conflicts earlier today.

@alarobric alarobric changed the title pipeline: outputs: loki: Add new header and uri options pipeline: outputs: loki: Add new header options May 22, 2024
@github-actions github-actions bot removed the Stale label May 23, 2024
@patrick-stephens patrick-stephens merged commit bbe823e into fluent:master May 24, 2024
4 checks passed
@alarobric alarobric deleted the loki_new_header_uri_options branch May 29, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict Waiting on conflict to be resolved by contributor waiting-for-user Waiting for user/contributors feedback or requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants