Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm-network): fix iptables rules #2388

Merged
merged 8 commits into from
Sep 30, 2024
Merged

fix(vm-network): fix iptables rules #2388

merged 8 commits into from
Sep 30, 2024

Conversation

kmd-fl
Copy link
Contributor

@kmd-fl kmd-fl commented Sep 26, 2024

Description

Modify iptables rules to support weird network setups.

Proposed Changes

  • find the network interface automatically
  • add the interface to the vm metrics

@kmd-fl kmd-fl requested a review from folex September 26, 2024 14:58
@enjenjenje enjenjenje added the e2e Run e2e workflow label Sep 27, 2024
nox/src/node.rs Outdated Show resolved Hide resolved
Copy link
Member

@mikevoronov mikevoronov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nox/src/node.rs Show resolved Hide resolved
nox/src/node.rs Show resolved Hide resolved
@kmd-fl kmd-fl enabled auto-merge (squash) September 30, 2024 13:54
@kmd-fl kmd-fl merged commit 757eacf into master Sep 30, 2024
14 checks passed
@kmd-fl kmd-fl deleted the fix-iptables branch September 30, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants