Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): add all GPUs on the host to a VM #2355

Closed
wants to merge 37 commits into from
Closed

feat(vm): add all GPUs on the host to a VM #2355

wants to merge 37 commits into from

Conversation

kmd-fl
Copy link
Contributor

@kmd-fl kmd-fl commented Aug 22, 2024

Description

Add all the GPUs to the XML of a newly created VM

Proposed changes

  1. When creating VMs, get the info about GPUs and add them to the VM XML
  2. Added the config setting that allows to enable/disable this functionallity
[vm]
allow_gpu = true

By default, GPUs are disabled

@kmd-fl kmd-fl added the e2e Run e2e workflow label Aug 22, 2024
Comment on lines 22 to 28
for device in info {
let device = device?;
let device_class = process_property_result(device.device_class())?;
if device_class == DisplayController {
result.push(process_property_result(device.location())?);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it in the functional style.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted but then with all those ? I decided to do it straightforward

Copy link
Member

@mikevoronov mikevoronov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@kmd-fl kmd-fl changed the base branch from vm-networking to master September 2, 2024 14:46
@kmd-fl kmd-fl closed this Sep 3, 2024
@kmd-fl
Copy link
Contributor Author

kmd-fl commented Sep 3, 2024

This is merged here #2356. The rest is here #2358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants