Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upload nox binaries to s3 #2298

Merged
merged 5 commits into from
Jul 23, 2024
Merged

chore: Upload nox binaries to s3 #2298

merged 5 commits into from
Jul 23, 2024

Conversation

nahsi
Copy link
Contributor

@nahsi nahsi commented Jul 2, 2024

No description provided.

@nahsi nahsi requested a review from folex July 2, 2024 11:00
Copy link

linear bot commented Jul 2, 2024

- name: Upload nox binary to s3
uses: osiegmar/s3-publisher-action@v1
with:
bucket: fluence-artifacts
Copy link
Member

@folex folex Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a less generic bucket? Like nox-releases or nox-distribution or fluence-provider-distribution.

So that eg all CCP binaries and all Nox binaries are clearly laid out without any noise around.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not only for nox but for all artifacts we have/we can have. Creating and configuring a bucket for each distribution adds a lot of code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have like just two S3 distributions: CLI and Nox+CCP.

It's benefical to keep things organised. Can change permissions there, easier to review and so on. Less noise, less brain power needed to manage it.

@nahsi nahsi requested a review from folex July 2, 2024 12:15
@nahsi nahsi merged commit 6dcbe67 into master Jul 23, 2024
5 checks passed
@nahsi nahsi deleted the FLU-685 branch July 23, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants