-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upload nox binaries to s3 #2298
Conversation
- name: Upload nox binary to s3 | ||
uses: osiegmar/s3-publisher-action@v1 | ||
with: | ||
bucket: fluence-artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use a less generic bucket? Like nox-releases
or nox-distribution
or fluence-provider-distribution
.
So that eg all CCP binaries and all Nox binaries are clearly laid out without any noise around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not only for nox but for all artifacts we have/we can have. Creating and configuring a bucket for each distribution adds a lot of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have like just two S3 distributions: CLI and Nox+CCP.
It's benefical to keep things organised. Can change permissions there, easier to review and so on. Less noise, less brain power needed to manage it.
No description provided.