New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api, lsp): Case classes exported to JS as normal JSONs #1151

Merged

DieMyst merged 1 commit into main from LNG-366-normal-jsons

Jun 7, 2024

Member

DieMyst commented Jun 7, 2024 •

edited

Loading

Description

Use js.Object instead of JSExport to create output classes with strict field names in JSON (without obfuscation)

Checklist

Corresponding issue has been created and linked in PR title.
Proposed changes are covered by tests.
Documentation has been updated to reflect the changes (if applicable).
I have self-reviewed my code and ensured its quality.
I have added/updated necessary comments to aid understanding.

Reviewer Checklist

Tests have been reviewed and are sufficient to validate the changes.
Documentation has been reviewed and is up to date.
Any questions or concerns have been addressed.


          from JSExport to js.Object

3e9979d

linear bot commented Jun 7, 2024

LNG-366 Make normal JSONs from exported case classes

DieMyst added the e2e label

DieMyst marked this pull request as ready for review

June 7, 2024 07:25

InversionSpaces approved these changes

View reviewed changes

DieMyst merged commit 037532f into main

15 of 22 checks passed

DieMyst deleted the LNG-366-normal-jsons branch

June 7, 2024 08:38

fluencebot mentioned this pull request

chore(main): release aqua 0.14.10 #1152

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e