fix(compiler): Return error if SemanticError occures [LNG-356] #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
language-server/language-server-api/src/test/scala/aqua/lsp/AquaLSPSpec.scala
Outdated
Show resolved
Hide resolved
| Raw.error("Failed to resolve default service id") | ||
| ): EitherT[Alg, Raw, ServiceRaw] = { | ||
| def errored = ErroredPart(expr.name.value) | ||
| for { |
There was a problem hiding this comment.
If error is always the same, this whole for could be rewritten to for on OptionT and converted to EitherT at the very end.
| @@ -23,4 +24,15 @@ trait Semantics[S[_], C] { | |||
| ast: Ast[S], | |||
| init: C | |||
| ): ProcessResult | |||
|
|
|||
| def stateToResult(state: CompilerState[S], ctx: C): ProcessResult = | |||
There was a problem hiding this comment.
Can we make it method of the CompilerState or object Semantics? It is strange for it to be a method of semantics trait, it is connected to it only by return type
InversionSpaces
approved these changes
Apr 17, 2024
Co-authored-by: InversionSpaces <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VSCode shows incorrect errors in exported functions
Proposed Changes
Turn state with errors to
CompileErrorImplementation Details
Because lsp creates context on errors too, it breaks on finalising headers and shows incorrect error.
Checklist
Reviewer Checklist