Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): Fix go-to-definition for abilities as arguments in functions [LNG-343] #1116

Merged
merged 5 commits into from
Apr 8, 2024
Merged

fix(lsp): Fix go-to-definition for abilities as arguments in functions [LNG-343] #1116

merged 5 commits into from
Apr 8, 2024

Conversation

DieMyst
Copy link
Member

@DieMyst DieMyst commented Apr 5, 2024 •
edited
Loading

Description

When there is multiple functions with same ability arguments, go-to-definition on these abilities work incorrect.

Proposed Changes

Point arguments on ability definition.

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@DieMyst DieMyst added the e2e Run e2e workflow label Apr 5, 2024
@linear Linear
Copy link

linear bot commented Apr 5, 2024

LNG-343 Multiple abilities and go-to-definition

@DieMyst DieMyst requested a review from InversionSpaces April 5, 2024 08:57
@DieMyst DieMyst enabled auto-merge (squash) April 8, 2024 09:37
@DieMyst DieMyst merged commit 07bea1a into main Apr 8, 2024
9 checks passed
@DieMyst DieMyst deleted the LNG-343-ability-tokens branch April 8, 2024 12:43
@fluencebot fluencebot mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InversionSpaces InversionSpaces InversionSpaces approved these changes

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DieMyst @InversionSpaces