Stay compatible with legacy PHP versions #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PHP 5.3.x is quite old and should not be used anymore (not supported for 9 years). But I don't see any disadvantage in merging this, except for worse readability. |
|
As there is still old PHP versions in production, I think it is a good idea to be compatible. Thank you for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I sometimes use the " PentesterLab Free VM - From SQL Injection to Shell" to teach application security, and in June students report that
p0wny@shelldoesn't work.In fact, the VM use a legacy PHP version (
X-Powered-By: PHP/5.3.3-7+squeeze3) andp0wny@shell v2023.05.10and above use short array syntax[]introduced in PHP 5.4.By replacing
[]by the old syntaxarray()the new version works well with old PHP versions 5 (and above of course). It's easier to do as changing the PHP version of the VM 😉.