feat: improve flake_ref parsing #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkenigs
reviewed
Mar 17, 2023
ysndr
commented
Mar 17, 2023
Comment on lines
+207
to
+212
| let wrapped_url = { | ||
| let mut url = url.clone(); | ||
| url.set_query(None); | ||
| url.set_fragment(None); | ||
| Url::parse(url.to_string().trim_start_matches("git+")).unwrap() | ||
| }; |
There was a problem hiding this comment.
This looks weird but is a result of the url lib being a bit too correct..
|
this is to be superseded by #15 |
|
implemented as #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?dir=#7?ref=and?rev=#3