-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide TypeScript definition for Portal.js #131
Comments
Okay. What are the other advantages of providing TypeScript definition? Is it just for Webstorm? At first glance, writing portal-tests.ts looks not easy since there are more than 200 test cases in the test suite and some cases require the server. I'll look at next weekend or so. |
WebStorm and Intellij Idea (and other JetBrains powered IDEs, I think) use typescript definitions extensively for better javascript/typescript code completion. TS definition also could be useful for Visual Studio. Let me know if you need help with testing of portal.d.ts |
Thanks, I'll ping you as I start work maybe the week after next. On Tue, Dec 3, 2013 at 1:30 AM, Viktor Gamov [email protected]:
|
@gAmUssA I just wrote portal.d.ts without test ts based on the 1.1-snapshot doc and will write JSdoc also. Please, review it. About portal.tests.ts, what should be tested? The portal test suite runs on browser, test client-side cases in client.js and server-side cases in server.js. server.js requires alive portal server and portal-java is used for that and will be replaced with a test-only server for Node #136. In client.js, mock transport does mock server. |
Please, provide portal.js library definition for TypeScript and for better Intellij/ Webstrom IDE support to DefinitelyTyped repository.
More details how to submit library to DefinitelyTyped
Thanks
The text was updated successfully, but these errors were encountered: