Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide TypeScript definition for Portal.js #131

Open
gAmUssA opened this issue Dec 2, 2013 · 5 comments
Open

Provide TypeScript definition for Portal.js #131

gAmUssA opened this issue Dec 2, 2013 · 5 comments

Comments

@gAmUssA
Copy link

gAmUssA commented Dec 2, 2013

Please, provide portal.js library definition for TypeScript and for better Intellij/ Webstrom IDE support to DefinitelyTyped repository.

More details how to submit library to DefinitelyTyped

Thanks

@gAmUssA gAmUssA closed this as completed Dec 2, 2013
@gAmUssA gAmUssA reopened this Dec 2, 2013
@flowersinthesand
Copy link
Owner

Okay. What are the other advantages of providing TypeScript definition? Is it just for Webstorm?

At first glance, writing portal-tests.ts looks not easy since there are more than 200 test cases in the test suite and some cases require the server.

I'll look at next weekend or so.

@gAmUssA
Copy link
Author

gAmUssA commented Dec 2, 2013

WebStorm and Intellij Idea (and other JetBrains powered IDEs, I think) use typescript definitions extensively for better javascript/typescript code completion. TS definition also could be useful for Visual Studio.

Let me know if you need help with testing of portal.d.ts

@flowersinthesand
Copy link
Owner

Thanks, I'll ping you as I start work maybe the week after next.

On Tue, Dec 3, 2013 at 1:30 AM, Viktor Gamov [email protected]:

WebStorm and Intellij Idea (and other JetBrains powered IDEs, I think) use
typescript definitions extensively for better javascript/typescript code
completion. TS definition also could be useful for Visual Studiohttp://blogs.msdn.com/b/mvpawardprogram/archive/2013/11/13/typescript-support-in-visual-studio-2013.aspx
.

Let me know if you need help with testing of portal.d.ts


Reply to this email directly or view it on GitHubhttps://github.com//issues/131#issuecomment-29632528
.

@flowersinthesand
Copy link
Owner

@gAmUssA I just wrote portal.d.ts without test ts based on the 1.1-snapshot doc and will write JSdoc also. Please, review it.
https://github.com/flowersinthesand/DefinitelyTyped/blob/portal/portal/portal.d.ts
http://flowersinthesand.github.io/portal/documentation/1.1-snapshot/portal/

About portal.tests.ts, what should be tested? The portal test suite runs on browser, test client-side cases in client.js and server-side cases in server.js. server.js requires alive portal server and portal-java is used for that and will be replaced with a test-only server for Node #136. In client.js, mock transport does mock server.
https://github.com/flowersinthesand/portal/blob/master/test/src/main/webapp/index.html

@flowersinthesand flowersinthesand removed this from the 1.2.0 milestone Feb 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants