Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some worker & service consts configurable. #284

Merged
merged 2 commits into from
May 27, 2022
Merged

Make some worker & service consts configurable. #284

merged 2 commits into from
May 27, 2022

Conversation

dkuryakin
Copy link
Contributor

@dkuryakin dkuryakin commented Apr 5, 2022 •
edited
Loading

  1. Add some extra logging. It's very helpful to debug rpc related issues. For example, only with this extra logging we found following error: grpc: received message larger than max (4296233 vs. 4194304)
  2. Add more flexibility by passing some of hardcoded params of workerpool to config: MaxJobErrorCount, DBJobPollInterval, AcceptedGracePeriod, ReSchedulableGracePeriod.
  3. Pass hardcoded PauseDuration to config.
  4. Add new config param GrpcMaxCallRecvMsgSize(default 16777216). Fix of error: grpc: received message larger than max (4296233 vs. 4194304).

@zaur zaur mentioned this pull request May 21, 2022
Closed
nvdtf
nvdtf approved these changes May 24, 2022
View reviewed changes
configs/configs.go
// Sleep duration in case of service isHalted
PauseDuration time.Duration `env:"PAUSE_DURATION" envDefault:"60s"`

GrpcMaxCallRecvMsgSize int `env:"GRPC_MAX_CALL_RECV_MSG_SIZE" envDefault:"16777216"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to put the max value as default.

@nvdtf nvdtf requested review from latenssi and nanuuki May 24, 2022 21:40
@latenssi
Copy link
Member

Thank you @dkuryakin!

@latenssi latenssi merged commit d3002fb into flow-hydraulics:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdtf nvdtf nvdtf approved these changes

@latenssi latenssi Awaiting requested review from latenssi

@nanuuki nanuuki Awaiting requested review from nanuuki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkuryakin @latenssi @nvdtf