Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to 1.17 #257

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Update Go to 1.17 #257

merged 1 commit into from
Jan 31, 2022

Conversation

110y
Copy link
Contributor

@110y 110y commented Jan 20, 2022

  • Update Go version for the go.mod
  • Fix Go container image version on the Dockerfile.
    • Basically, it would be better to fix the image version as much as possible for reproducible builds.

gorm.io/gorm v1.22.5
)

require (
Copy link
Contributor Author

@110y 110y Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After 1.17, now indirect modules are grouped by another require.

https://golang.org/doc/go1.17#go-command

For the go command to correctly resolve transitive imports using the pruned module graph, the go.mod file for each module needs to include more detail about the transitive dependencies relevant to that module. If a module specifies go 1.17 or higher in its go.mod file, its go.mod file now contains an explicit require directive for every module that provides a transitively-imported package. (In previous versions, the go.mod file typically only included explicit requirements for directly-imported packages.)

@110y
Copy link
Contributor Author

110y commented Jan 24, 2022

@latenssi @nanuuki

How about this change...?

@latenssi
Copy link
Member

latenssi commented Jan 25, 2022

@110y Thank you for the PR! This PR adds new dependencies, we are going through them one by one. This is a bit laborious and as updating the Go version is not a priority I hope you understand this PR might take a while :) I did the update on main and it produced the exact same version of the go.mod file you are presenting here, so this PR seems good to go 👍 We will be merging it in tomorrow.

@latenssi latenssi merged commit e9ae26e into flow-hydraulics:main Jan 31, 2022
@110y 110y deleted the update-go branch March 15, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants