Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a testcase for multiple concurrent account create #236

Merged
merged 18 commits into from
Dec 21, 2021
Merged

Add a testcase for multiple concurrent account create #236

merged 18 commits into from
Dec 21, 2021

Conversation

latenssi
Copy link
Member

No description provided.

@latenssi latenssi mentioned this pull request Dec 15, 2021
Open
@latenssi latenssi changed the title Add a testcase for multiple simultaneous account create Add a testcase for multiple concurrent account create Dec 17, 2021
nanuuki
nanuuki requested changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@nanuuki nanuuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, see comments :) After those it's good to go

tests/accounts_service_test.go Outdated Show resolved Hide resolved
tests/accounts_service_test.go Outdated Show resolved Hide resolved
tests/internal/test/service.go Outdated Show resolved Hide resolved
tests/accounts_service_test.go Outdated Show resolved Hide resolved
main_test.go Outdated Show resolved Hide resolved
@latenssi latenssi force-pushed the latenssi/test-simultaenous-account-creation branch from fe6bae3 to 2c9e1de Compare December 21, 2021 07:35
nanuuki
nanuuki reviewed Dec 21, 2021
View reviewed changes
jobs/jobs.go Outdated Show resolved Hide resolved
@latenssi latenssi force-pushed the latenssi/test-simultaenous-account-creation branch from 323ff02 to 063e14f Compare December 21, 2021 08:26
nanuuki
nanuuki approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@nanuuki nanuuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

@latenssi latenssi merged commit 030810b into main Dec 21, 2021
@latenssi latenssi deleted the latenssi/test-simultaenous-account-creation branch December 21, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanuuki nanuuki nanuuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@latenssi @nanuuki