Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for maintenance mode #222

Merged
merged 7 commits into from
Dec 8, 2021
Merged

Conversation

latenssi
Copy link
Member

@latenssi latenssi commented Nov 30, 2021

  • Add an HTTP endpoint to get and set system settings; settings that should be shared with all instances and not requiring a instance restart to update
  • Add system setting for maintenance mode
  • Add API docs for system settings

When the system is in maintenance mode, all jobs will be halted. Basically this means all Flow transactions are halted until maintenance mode is disabled. Synchronous calls to the API (the resulting transactions) will still go though to Flow, please avoid using them.

Chain listener is also halted in maintenance mode, so no Flow events will be processed during maintenance.

resolves #93

@latenssi latenssi linked an issue Nov 30, 2021 that may be closed by this pull request
@latenssi latenssi marked this pull request as ready for review December 1, 2021 11:30
@latenssi latenssi requested a review from nanuuki December 1, 2021 11:53
Base automatically changed from latenssi/tx-throttling to main December 1, 2021 12:20
Copy link
Contributor

@nanuuki nanuuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There don't seem to be any tests for the new /system endpoints, maybe add some basic test cases for them? :)

Copy link
Contributor

@nanuuki nanuuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@latenssi latenssi merged commit 7124c4f into main Dec 8, 2021
@latenssi latenssi deleted the latenssi/maintenance-flag branch December 8, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance flag support
2 participants