-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for maintenance mode #222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
latenssi
force-pushed
the
latenssi/maintenance-flag
branch
from
December 1, 2021 11:08
82492a7
to
ce6599a
Compare
latenssi
force-pushed
the
latenssi/maintenance-flag
branch
from
December 1, 2021 11:22
707b626
to
423fa8d
Compare
latenssi
force-pushed
the
latenssi/maintenance-flag
branch
from
December 1, 2021 11:27
805c287
to
110eae5
Compare
nanuuki
reviewed
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There don't seem to be any tests for the new /system
endpoints, maybe add some basic test cases for them? :)
nanuuki
approved these changes
Dec 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the system is in maintenance mode, all jobs will be halted. Basically this means all Flow transactions are halted until maintenance mode is disabled. Synchronous calls to the API (the resulting transactions) will still go though to Flow, please avoid using them.
Chain listener is also halted in maintenance mode, so no Flow events will be processed during maintenance.
resolves #93