Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrailScraper is not timezone-aware #39

Closed
flosell opened this issue Apr 8, 2018 · 1 comment
Closed

TrailScraper is not timezone-aware #39

flosell opened this issue Apr 8, 2018 · 1 comment
Labels
bug

Comments

@flosell
Copy link
Owner

flosell commented Apr 8, 2018

trailscraper seems to use datetimes without timezone information, leading to strange effects when specifying relative timestamps (e.g. now) since the local timestamp is then compared with timestamps used by AWS (which are always UTC):

  • trailscraper download might download the wrong files
  • trailscraper generate might filter for the wrong records
@flosell flosell added the bug label Apr 8, 2018
flosell added a commit that referenced this issue Apr 8, 2018
@flosell
Make trailscraper timezone-aware (#39). Also rename test to make sure…
540b3d0 
… it's executed and use fixed dateparser version as newer dateparsers seem not to work with some relative timestamps
@flosell
Copy link
Owner Author

flosell commented Apr 8, 2018

Fixed.

@flosell flosell closed this as completed Apr 8, 2018
flosell added a commit that referenced this issue Apr 8, 2018
@flosell
Make trailscraper timezone-aware (#39). Also rename test to make sure…
678dfe1 
… it's executed and use fixed dateparser version as newer dateparsers seem not to work with some relative timestamps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flosell