Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json syntax highlight #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gordonbondon
Copy link
Contributor

Prism provides their own live syntax highlight functionality https://live.prismjs.com/ + https://github.com/PrismJS/live, so I decided to give it a try. Results look like this:

json-syntax.mov

Fixes #27

@flosell
Copy link
Owner

flosell commented Nov 2, 2021

Hey @gordonbondon, good start!

One thing I noticed: There seems to be something odd going on with the PrismJS stuff and the underlying textbox. I can see the red spellcheck lines (I think that can be easily disabled) and when selecting I see the underlying text which looks very odd:

Screen.Recording.2021-11-02.at.07.56.02.mov

Also, two minor things:

  • The input textbox looks quite small compared to the output textbox, probably needs a bit of styling
  • The PR conflicts since I've merged your other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add syntax highlighting in web frontend
2 participants