Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump mongoose to ~4.0.0 #114

Merged
merged 14 commits into from May 6, 2015
Merged

chore(deps): bump mongoose to ~4.0.0 #114

merged 14 commits into from May 6, 2015

Conversation

Zertz
Copy link
Collaborator

@Zertz Zertz commented May 4, 2015

  • Introduces many breaking changes, lib needs updates

Pier-Luc Gendreau added 2 commits May 4, 2015 16:53
- Introduces many breaking changes, lib needs updates
- Full error object is always passed
- Status is always set on the error object
- For find ops, distinguish between `err` (400) and `!item` (404)
- Users should instead implement a custom onError handler
@Zertz
Copy link
Collaborator Author

Zertz commented May 4, 2015

Don't merge this just yet, it's broken in many ways at the moment!

@Zertz
Copy link
Collaborator Author

Zertz commented May 5, 2015

@florianholzapfel There!

I've also added a changelog with the breaking changes which are:

This release is no longer compatible with mongoose 3

  • updated mongoose to version 4
  • removed fullErrors, implement a custom onError handler instead

Of course, the ~0.7.0 release should kept since mongoose 4 is anything but widespread at the moment.

I've also taken the liberty to refactor how defaults are set. It now relies on lodash instead which should be more reliable than the look that was used before.

florianholzapfel added a commit that referenced this pull request May 6, 2015
chore(deps): bump mongoose to ~4.0.0
@florianholzapfel florianholzapfel merged commit aafcdb5 into florianholzapfel:1.0.0-dev May 6, 2015
@florianholzapfel
Copy link
Owner

@Zertz thank you very much for this pr. you are awesome!

@Zertz
Copy link
Collaborator Author

Zertz commented May 6, 2015

@florianholzapfel Moving this into an issue, it'll be easier to follow along

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants