Skip to content
This repository has been archived by the owner on Jan 6, 2024. It is now read-only.

Possible to change status bar color & preview image quality #34

Merged
merged 2 commits into from
Jan 30, 2018
Merged

Possible to change status bar color & preview image quality #34

merged 2 commits into from
Jan 30, 2018

Conversation

pak-amsiq
Copy link
Contributor

SwiftLint should be alright 👍

@@ -54,6 +59,9 @@ class GBHFacebookAlbumPicker: UITableViewController {

// Start Facebook login
self.doFacebookLogin()

// Statusbar
self.setNeedsStatusBarAppearanceUpdate()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is useful. Maybe it's only required when you change a status bar propreties when the controller is already visible ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I just removed these lines

@@ -80,6 +85,9 @@ class GBHPhotoPickerViewController: UIViewController {

// Fetch photos if empty
self.getPhotos()

// Statusbar
self.setNeedsStatusBarAppearanceUpdate()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is useful. Maybe it's only required when you change a status bar propreties when the controller is already visible ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I just removed these lines

@floriangbh
Copy link
Owner

Thanks :-)

@floriangbh
Copy link
Owner

Your last commit is "In progress" ?
Can't merge until it's finish :-)

@pak-amsiq
Copy link
Contributor Author

pak-amsiq commented Jan 28, 2018

Wasn't on purpose that the last commit was uploaded for this PR, as it isn't ready atm.

These two commits should be ready for merging, with your latest comments included :-)

Please make a release as soon as possible :-)

@pak-amsiq pak-amsiq changed the title Possible to change status bar color Possible to change status bar color & preview image quality Jan 28, 2018
@floriangbh floriangbh merged commit f9e2255 into floriangbh:develop Jan 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants