-
Notifications
You must be signed in to change notification settings - Fork 61
Possible to change status bar color & preview image quality #34
Conversation
@@ -54,6 +59,9 @@ class GBHFacebookAlbumPicker: UITableViewController { | |||
|
|||
// Start Facebook login | |||
self.doFacebookLogin() | |||
|
|||
// Statusbar | |||
self.setNeedsStatusBarAppearanceUpdate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is useful. Maybe it's only required when you change a status bar propreties when the controller is already visible ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I just removed these lines
@@ -80,6 +85,9 @@ class GBHPhotoPickerViewController: UIViewController { | |||
|
|||
// Fetch photos if empty | |||
self.getPhotos() | |||
|
|||
// Statusbar | |||
self.setNeedsStatusBarAppearanceUpdate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is useful. Maybe it's only required when you change a status bar propreties when the controller is already visible ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I just removed these lines
Thanks :-) |
Your last commit is "In progress" ? |
Wasn't on purpose that the last commit was uploaded for this PR, as it isn't ready atm. These two commits should be ready for merging, with your latest comments included :-) Please make a release as soon as possible :-) |
SwiftLint should be alright 👍