Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generator for ZBeam #737

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Add generator for ZBeam #737

merged 1 commit into from
Dec 15, 2024

Conversation

jasondunsmore
Copy link
Contributor

I needed this to make a channel to hide a cable up against a wall corner.

@ffesti
Copy link
Contributor

ffesti commented Dec 13, 2024

3 f edges and only one F edge are unlikely to all fit together.

This also obviously is an U beam...

@jasondunsmore jasondunsmore force-pushed the zbeam branch 3 times, most recently from 82982cc to bea8e9e Compare December 13, 2024 22:09
@jasondunsmore
Copy link
Contributor Author

3 f edges and only one F edge are unlikely to all fit together.

Should be fixed.

This also obviously is an U beam...

I added a note about this. Also added an option to make a flanged U beam.

@jasondunsmore jasondunsmore force-pushed the zbeam branch 2 times, most recently from 4fb6589 to 6c55261 Compare December 14, 2024 00:24
@florianfesti
Copy link
Owner

Looks good. I was about to just hit merge. I wonder if you can add a sample picture. If you don't want to jump all the hoops listed in https://github.com/florianfesti/boxes/blob/master/CONTRIBUTING.rst#provide-photos-for-generators I am happy to deal with that. Just add the image to the PR in static/samples/

@jasondunsmore
Copy link
Contributor Author

Sure. I have some samples cut out, so I will try to take a photo today.

@jasondunsmore jasondunsmore force-pushed the zbeam branch 3 times, most recently from 3c84f1c to e82b023 Compare December 14, 2024 21:46
@jasondunsmore
Copy link
Contributor Author

I see that pytest is failing because the svg file references the URL of my local boxes.py instance instead of https://boxes.hackerspace-bamberg.de, but I'm not sure how to fix it.

@jasondunsmore @florianfesti
Add generator for Z-Beam or U-Beam
c1eeda8 
Can be a Z-Beam or a U-Beam depending on the orientation of the
pieces. With the --flanged_ubeam option, a 4th piece is added for a flange.
@florianfesti florianfesti merged commit 819fecb into florianfesti:master Dec 15, 2024
3 checks passed
@florianfesti
Copy link
Owner

Yeah, the CI is more than a bit finicky. Fixed the PR. But the CI and its docs needs a bit more polishing to make this easier for contributors.

@florianfesti
Copy link
Owner

Anyway, thanks a lot for the generator!

@florianfesti
Copy link
Owner

florianfesti commented Dec 15, 2024 •
edited
Loading

Would you mind posting the output of python -VV? There is some difference between the output depending on the Python version and/or operating system. The files in the example dir have a space before /> while yours does not. And I am trying to track these differences down to get rid of them ad some point in the future...

@florianfesti
Copy link
Owner

@Rotzbua Any idea about this?

@jasondunsmore
Copy link
Contributor Author

Would you mind posting the output of python -VV? There is some difference between the output depending on the Python version and/or operating system. The files in the example dir have a space before /> while yours does not. And I am trying to track these differences down to get rid of them ad some point in the future...

$ python3 -VV
Python 3.11.2 (main, Sep 14 2024, 03:00:30) [GCC 12.2.0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasondunsmore @ffesti @florianfesti