Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check isnan Width and Height #987

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Check isnan Width and Height #987

merged 1 commit into from
Feb 1, 2024

Conversation

kassane
Copy link
Contributor

@kassane kassane commented Feb 1, 2024

based on D bindings: kassane/sokol-d#5 (comment)

cc: @floooh

@floooh
Copy link
Owner

floooh commented Feb 1, 2024

Makes sense, yeah. I'll wait for the CI tests to go green (because I only see isnan() as C99 feature and wonder if C++ knows it too...

Do you know how those values became NaNs in the first place? If it's already mentioned in the thread just point me to the right comment :)

@floooh
Copy link
Owner

floooh commented Feb 1, 2024

to the fact that the float/double in D is nan instead of 0.0f by default.

...wait does that mean that an unitialized float/double in D is initialized as NaN? That would be quite crazy because NaNs have a tendency to spread (they turn every expression result into NaNs too).

@floooh floooh merged commit 02b1dae into floooh:master Feb 1, 2024
23 checks passed
@floooh
Copy link
Owner

floooh commented Feb 1, 2024

Ok all green and merged. Thanks!

@kassane kassane deleted the not_nan branch February 1, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants