Change getRawX to getX on the Android #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use the `getRawX` method in multi-window mode on the Android platform, it will not accurately correspond to the touch position of the current window.
|
Thanks! I'll check if getX() etc... returns the same values for the "single window case" in the sokol samples and then merge. |
|
Btw, if you create your pull requests from a dedicated and uniquely named branch (not your master branch) you'd be making my life a tiny bit easier ;) (for future PRs) |
|
Looking good and merged. Thanks! I'll also add a small changelog entry. |
Got it, will use unique branch for future PRs. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If use the
getRawXgetRawYmethod in multi-window mode on the Android platform, it will not accurately correspond to the touch position of the current window.