-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp MSAA images and render passes. #816
Comments
...this seems to be a separate issue, also happens on the master branch... need to bisect whether this is a sokol-gfx GL backend regression, or a macOS problem (the |
PR: #834 |
This brings the API closer to Metal and WebGPU and addresses a couple of long-standing issues:
sg_image
andsg_end_pass()
sg_pass_attachment_desc
gets a separate resolve image entry, if this is present, an MSAA resolve will be performed in sg_end_pass() => NOTE: depth/stencil attachments cannot be MSAA-resolved (see WebGPU spec), for color attachment resolve, there will be a separatesg_pass_desc.resolve_attachments[]
array.sg_action
is split intosg_load_action
andsg_store_action
, wheresg_store_action
only containsdontcare
andstore
(this is similar to WebGPU, but not similar to Metal - e.g. the Metal store actions 'resolve' and 'resolve-and-store' are implicit by the presence or absence of a resolve attachment...optional: get rid of baked pass objects completely? It's unclear whether would actually still be needed even with a Vulkan backend in place.=> still a good idea in the GL backends, because framebuffer setup is pretty elaborate.Related issues and PRs:
Also see:
The text was updated successfully, but these errors were encountered: