Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sokol_imgui.h doesn't work with latest version of cimgui.h #1105

Closed
comblock opened this issue Sep 9, 2024 · 2 comments
Closed

sokol_imgui.h doesn't work with latest version of cimgui.h #1105

comblock opened this issue Sep 9, 2024 · 2 comments
Assignees

Comments

@comblock
Copy link

comblock commented Sep 9, 2024

When trying to compile a project using sokol_imgui.h and the latest version of cimgui, I get these errors:

lib/sokol/util/sokol_imgui.h:2221:13: error: no member named 'SetClipboardTextFn' in 'struct ImGuiIO'
 2221 |         io->SetClipboardTextFn = _simgui_set_clipboard;
      |         ~~  ^
lib/sokol/util/sokol_imgui.h:2222:13: error: no member named 'GetClipboardTextFn' in 'struct ImGuiIO'
 2222 |         io->GetClipboardTextFn = _simgui_get_clipboard;
      |         ~~  ^

These struct members were removed in the latest commit: cimgui/cimgui@ed017a0#diff-8c5bc66a0b4aae002c8b733763a8e1157968b9ef4e49ec9f25186b4962082462L1067-L1068

@floooh
Copy link
Owner

floooh commented Sep 10, 2024

Thanks for the heads up, I guess the Dear ImGui API has changed too but has backward compatibility wrappers in place. It probably makes sense to also update the C++ parts to the latest API updates while at it. I'll try to fix that 'soon-ish'.

@floooh floooh self-assigned this Sep 10, 2024
@floooh floooh closed this as completed in 1eb96dd Sep 10, 2024
@floooh
Copy link
Owner

floooh commented Sep 10, 2024

Ok fixed via 1eb96dd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants