Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for wasm using emscripten #31

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

Nazariglez
Copy link
Contributor

This PR adds support for wasm using emscripten when consuming sokol as dependency from another project.

@floooh
Copy link
Owner

floooh commented Jul 2, 2024

Nice! I have a couple of requests:

@Nazariglez
Copy link
Contributor Author

Sure thing! I will do the changes and I'll added the readme section. I am having some issues with sokol and images, but is not related to emscripten so I'll open a new issue for that.

@Nazariglez
Copy link
Contributor Author

I am not abandoned this, just have had short time, but I am still working a bit with sokol and nim, and I have to say that I am learning quite a lot about sokol and nim itself reading your codebase. I'll do the changes and update the PR in the next weeks. Sorry for the delay!

@Nazariglez
Copy link
Contributor Author

Changes made, the readme is updated and sokol binding generator is updated here. floooh/sokol#1086

@floooh floooh merged commit 3fe27d2 into floooh:master Jul 30, 2024
2 checks passed
@floooh
Copy link
Owner

floooh commented Jul 30, 2024

I spotted two typos in the readme but I'll just fix them directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants