Use cmake's target_sources(), and general cmake file cleanup. #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt to use the 'new-ish' cmake target_sources() command. Main difference is that an (empty) target is now already created in the
fips_begin_*
calls, not infips_end()
. This allows a much simpler internal structure because target items can now be added immediately in the other fips functions instead of being stored untilfips_end_*()
is called.Cleanup changes:
(all deprecated functions now print a warning message, but still work - but will be removed in the next cleanup round)
TODO:
fips.yml: header dirs and module exports in fips.yml should be deprecated, this should all be defined via cmake => add deprecation messages for this!(header exports are needed for header-only libs, but figure out if module exports are actually still needed) => module exports make sense because they basically just trigger the generation of an 'add_subdirectory()' in the toplevel project, the naming is just a bit unfortunate (should be exported targets instead)FIPS_OSX_STANDARD_FRAMEWORKS should be removedeh, just keep it in, Win32 has tons of standard link libraries tooadd a fips_target() function which returns the current target between begin/end, and otherwise fails (but do NOT clear the CurTargetName variable in fips_end() for backward compatibility, instead use a separate flag)no such thing as return values in cmake, and the alternatives would be too messy