Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding align=8 in structure definition does not change anything in generated c code. #456

Open
harshitha-bt opened this issue Jan 21, 2016 · 3 comments

Comments

@harshitha-bt
Copy link

In openflow-input/standars1.3, struct of_table_feature_prop_instruction( align=8, length_includes_align=False ) does not have any effect in the generated c code, whereas python takes these align params into consideration and generates a function "pad_to(alignment)"

@andi-bigswitch
Copy link
Contributor

This was discussed on the ONL group:
https://groups.google.com/forum/#!topic/opennetworklinux/4pfJdkJNChQ

@harshitha-bt any chance you might be able to contribute the patch for C (if it applies to loxigen in general)

@harshitha-bt
Copy link
Author

Hi Andreas,

The fix I made worked well for my purpose, but not too sure if it is a
generic solution.
I can anyway post it here for review and see if it looks ok
On 26 Feb 2016 20:19, "Andreas Wundsam" [email protected] wrote:

This was discussed on the ONL group:
https://groups.google.com/forum/#!topic/opennetworklinux/4pfJdkJNChQ

@harshitha-bt https://github.com/harshitha-bt any chance you might be
able to contribute the patch for C (if it applies to loxigen in general)


Reply to this email directly or view it on GitHub
#456 (comment).

@andi-bigswitch
Copy link
Contributor

@harshitha-bt:

I can anyway post it here for review and see if it looks ok

Sure, would be great if you could open a PR - might help others!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants