You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Storage is currently implemented using a Vec as a backing storage. This becomes inefficient for huge window sizes, as the whole array needs to be shifted on every call to next()sometimes.
As noted in #1 it's very hard to implement Storage generically over any container.
One would lose the ability of Window to deref to a (mut) slice.
Window probably has to implement Iterator or Index/IndexMut.
I'd be happy to merge a PR that implements Storage generically over containers if good solutions to the above problems are found and if no functionality gets lost.
Anyway I'd also merge a PR implementing another adaptor, which uses a VecDeque or anything efficient for huge window sizes.
The text was updated successfully, but these errors were encountered:
Storage is currently implemented using a Vec as a backing storage. This becomes inefficient for huge window sizes, as the whole array needs to be shifted
on every call to next()sometimes.As noted in #1 it's very hard to implement Storage generically over any container.
I'd be happy to merge a PR that implements Storage generically over containers if good solutions to the above problems are found and if no functionality gets lost.
Anyway I'd also merge a PR implementing another adaptor, which uses a VecDeque or anything efficient for huge window sizes.
The text was updated successfully, but these errors were encountered: