Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs polishing #1

Closed
3 of 4 tasks
flo-l opened this issue Nov 23, 2015 · 2 comments
Closed
3 of 4 tasks

Needs polishing #1

flo-l opened this issue Nov 23, 2015 · 2 comments

Comments

@flo-l
Copy link
Owner

flo-l commented Nov 23, 2015

Before announcing this on reddit etc. this repo needs some polishing.

Wishlist

  • better readme
  • shorter/better type names (SlidingWindowStorage is horrible)
  • more storage types (VecDeque), maybe a trait so users can implement their own won't be done
  • macro to make usage even easier Is this really needed?
@flo-l
Copy link
Owner Author

flo-l commented Dec 18, 2015

OK it's very complicated to implement Storage generically. One would lose the ability of window to deref to a slice etc.

So it won't be done. For very huge Windows maybe a separate crate or at least a separate iterator adaptor should be developed.

@flo-l
Copy link
Owner Author

flo-l commented Jun 16, 2017

This crate looks good to me now. I'll still happily accept any contributions of course :)

@flo-l flo-l closed this as completed Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant