Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 secondary info indexes on individual elements #584

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

MrPrisoner
Copy link
Contributor

Fix secondary info indexes on individual elements.
Fix Power Outage table on readme

@MrPrisoner
Copy link
Contributor Author

MrPrisoner commented Apr 20, 2024

@flixlix Hey bud, I fixed an issue where individual elements with display_zero: false will display the wrong element's secondary info because of hard-coded indexes.

Not sure if I should be making PR to main or a release branch. You're also welcome to cherry pick if you want to pull it in.

@flixlix flixlix changed the base branch from main to v0.2.2-release April 21, 2024 14:49
@flixlix
Copy link
Owner

flixlix commented Apr 21, 2024

Hey @MrPrisoner,

thank you very much for this PR, very good find on this bug fix!

I'm fine with the readme changes, no need for an additional PR.

I'll merge this for version 0.2.2 :)

@MrPrisoner MrPrisoner changed the title Fix secondary info indexes on individual elements fix: 🐛 secondary info indexes on individual elements Apr 21, 2024
@flixlix flixlix merged commit 4c81aed into flixlix:v0.2.2-release Apr 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants