Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use dark scheme for browser built-in inputs/scrolls in dark mode #3601

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented Nov 8, 2024

UI uses some elements for input date, time, etc... They have extra icon
which very hard to see in dark mode and their popups have white
background.

Before

image

After

image

…mode

UI uses some elements for input date, time, etc... They have extra icon
which very hard to see in dark mode and their popups have white
background.

Signed-off-by: Roman Dmytrenko <[email protected]>
@erka erka requested a review from a team as a code owner November 8, 2024 12:59
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (e3a4769) to head (94f8b85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3601   +/-   ##
=======================================
  Coverage   64.14%   64.14%           
=======================================
  Files         169      169           
  Lines       16956    16956           
=======================================
  Hits        10876    10876           
  Misses       5400     5400           
  Partials      680      680           
Flag Coverage Δ
unittests 64.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! ty

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Nov 8, 2024
@kodiakhq kodiakhq bot merged commit d83d68b into main Nov 8, 2024
40 checks passed
@kodiakhq kodiakhq bot deleted the dark-browser-input branch November 8, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants