Supports negative years for date and timestamp types #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telser
approved these changes
Nov 9, 2024
Previously we were ISO8601 encoding/decoding dates and timestamps with negative years, however PostgreSQL uses a "BC" suffix to indicate negative years. I added support for this syntax to the `Day`, `UTCTime`, and `LocalTime` `SqlType`s, and expanded the range of years generated in testing to ensure we're handling the negative years correctly.
jlavelle
force-pushed
the
nebula/support-negative-years
branch
from
aae6554 to
c812edf
Compare
|
There's an off-by-one bug because PostgreSQL considers |
|
Closing for now because I have to make rather significant changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were ISO8601 encoding/decoding dates and timestamps with negative years, however PostgreSQL uses a "BC" suffix to indicate negative years. I added support for this syntax to the
Day,UTCTime, andLocalTimeSqlTypes, and expanded the range of years generated in testing to ensure we're handling the negative years correctly.Closes #380.