Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/fix_work_without_sd_card #48

Merged
merged 2 commits into from
Nov 3, 2023
Merged

feature/fix_work_without_sd_card #48

merged 2 commits into from
Nov 3, 2023

Conversation

mlyubimov
Copy link
Member

@mlyubimov mlyubimov commented Nov 2, 2023 •
edited
Loading

@mlyubimov mlyubimov self-assigned this Nov 2, 2023
@mlyubimov mlyubimov changed the title feature/fix)work_without_sd_card feature/fix_work_without_sd_card Nov 2, 2023
Slipn3r
Slipn3r requested changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@Slipn3r Slipn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InstalledApps should open the missing SD card dialog when opened with connected flipper with no SD.
Another way of solving both this and disconnected flipper scenarios is to disable the "Installed" button in AppsLayout when there's nothing to show.

@mlyubimov
Copy link
Member Author

InstalledApps should open the missing SD card dialog when opened with connected flipper with no SD. Another way of solving both this and disconnected flipper scenarios is to disable the "Installed" button in AppsLayout when there's nothing to show.

Done ✅

@Slipn3r Slipn3r merged commit b1be0df into dev Nov 3, 2023
@Slipn3r Slipn3r deleted the feature/fix_work_without_sd_card branch November 3, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Slipn3r Slipn3r Slipn3r requested changes

Assignees

@mlyubimov mlyubimov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlyubimov @Slipn3r